fix: Handle empty message content for suggestion threads #1265
+23
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Ensures a fallback thread title is provided when the original message content is empty. The thread title will now default to the message author's name in such cases, preventing empty or uninformative thread titles. Co-authored-by: billpapat <50835814+billpapat@users.noreply.github.com> Co-authored-by: Chris Sdogkos <work@chris-sdogkos.com> Mentored-by: Chris Sdogkos <work@chris-sdogkos.com>
CI/CD is failing without this commit. Co-authored-by: billpapat <50835814+billpapat@users.noreply.github.com> Co-authored-by: Chris Sdogkos <work@chris-sdogkos.com> Mentored-by: Chris Sdogkos <work@chris-sdogkos.com>
christolis
force-pushed
the
fix/image-suggestion
branch
from
14121b8 to
629ac8c
Compare
Zabuzard
requested changes
Jun 29, 2025
application/src/main/java/org/togetherjava/tjbot/features/basic/SuggestionsUpDownVoter.java
Outdated
Show resolved
Hide resolved
christolis
requested changes
Jun 29, 2025
There was a problem hiding this comment.
+ what @Zabuzard suggested. We should prioritize code readability.
application/src/main/java/org/togetherjava/tjbot/features/basic/SuggestionsUpDownVoter.java
Outdated
Show resolved
Hide resolved
Zabuzard
requested changes
Jun 29, 2025
application/src/main/java/org/togetherjava/tjbot/features/basic/SuggestionsUpDownVoter.java
Outdated
Show resolved
Hide resolved
1) Created channels without title will default to "username's suggestions" 2) Change String threadTitle to final 3) ThreadTitle logic implemented in a helper method Co-authored-by: Ethan McCue <5004262+bowbahdoe@users.noreply.github.com>
christolis
requested changes
Jun 29, 2025
application/src/main/java/org/togetherjava/tjbot/features/basic/ThreadTitle.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/basic/ThreadTitle.java
Outdated
Show resolved
Hide resolved
Addresses code review by @christolis. Co-authorized-by: Chris Sdogkos <work@chris-sdogkos.com> Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com> Signed-off-by: billpapat <50835814+billpapat@users.noreply.github.com>
Zabuzard
requested changes
Jun 30, 2025
application/src/main/java/org/togetherjava/tjbot/features/basic/ThreadTitle.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/basic/SuggestionsUpDownVoter.java
Outdated
Show resolved
Hide resolved
Zabuzard
requested changes
Jun 30, 2025
application/src/main/java/org/togetherjava/tjbot/features/basic/SuggestionsUpDownVoter.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/basic/SuggestionsUpDownVoter.java
Outdated
Show resolved
Hide resolved
Taz03
changed the title
Taz03
requested changes
Jul 1, 2025
application/src/main/java/org/togetherjava/tjbot/features/basic/SuggestionsUpDownVoter.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/basic/SuggestionsUpDownVoter.java
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/basic/SuggestionsUpDownVoter.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/basic/SuggestionsUpDownVoter.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/basic/SuggestionsUpDownVoter.java
Outdated
Show resolved
Hide resolved
Zabuzard
requested changes
Jul 1, 2025
There was a problem hiding this comment.
could u add some screenshots to the PR please that showcase/demo the feature in practice? its always difficult to review these things when u cant see how it actually looks in practice. often one also spots improvement opportunities that way 🙂
code-wise everything is fine by me now 👍
Zabuzard
approved these changes
Jul 5, 2025
Taz03
approved these changes
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures a fallback thread title is provided when the original message content is empty. The thread title will now default to the message author's nickname in such cases, preventing empty or uninformative thread titles. Closes #1198